Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete vendor from test-infra #14036

Merged
merged 4 commits into from
Aug 23, 2019
Merged

Delete vendor from test-infra #14036

merged 4 commits into from
Aug 23, 2019

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Aug 22, 2019

Go modules no longer uses this directory, and bazel is more efficient without it.

  • Update BUILD.bazel rules to look for @com_github_foo_bar//whatever instead of //vendor/github.com/foo/bar/whatever
  • Update hack scripts to use this

/assign @Katharine @stevekuznetsov @michelle192837

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2019
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/ghproxy Issues or PRs related to code in /ghproxy area/gopherage Issues or PRs related to code in /gopherage area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) area/images area/kubetest area/label_sync Issues or PRs related to code in /label_sync area/prow Issues or PRs related to prow area/prow/artifact-uploader Issues or PRs related to prow's artifact-uploader component area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/clonerefs Issues or PRs related to prow's clonerefs component area/prow/config-bootstrapper Issues or PRs related to prow's config-bootstrapper utility area/prow/crier Issues or PRs related to prow's crier component area/prow/deck Issues or PRs related to prow's deck component area/prow/entrypoint Issues or PRs related to prow's entrypoint component area/prow/gcsupload Issues or PRs related to prow's gcsupload component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/hook Issues or PRs related to prow's hook component approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/horologium Issues or PRs related to prow's horologium component area/prow/initupload Issues or PRs related to prow's initupload component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component labels Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9106daec5e8afb3dcd7a50f7a67c2a0f8a994c0e

@fejta
Copy link
Contributor Author

fejta commented Aug 22, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2019
@fejta fejta mentioned this pull request Aug 22, 2019
Closed
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@fejta
Copy link
Contributor Author

fejta commented Aug 22, 2019

Now with passing tests!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2019
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2ea2d6d093e22032ed33bdbaffc4dd360535af2f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, michelle192837

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fejta,michelle192837]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stevekuznetsov
Copy link
Contributor

Does this have any impact on downstream repositories importing Prow types, etc?

@fejta
Copy link
Contributor Author

fejta commented Aug 23, 2019

Is there a specific scenario you're concerned about?

This should not have a downstream impact as they can use our go.mod to create a correct version of vendor or go.mod for their repo.

@stevekuznetsov
Copy link
Contributor

Generally importing test-infra is an absolute nightmare since any package you pull in has a habit of pulling in ... idk ... the world? Knative? k8s? Everything? So just wanted to make sure this did not make that materially worse

@fejta
Copy link
Contributor Author

fejta commented Aug 23, 2019

Definitely won't make things worse, may make things better.

@fejta
Copy link
Contributor Author

fejta commented Aug 23, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 23, 2019
@fejta fejta mentioned this pull request Aug 23, 2019
Closed
@k8s-ci-robot k8s-ci-robot merged commit 6304ab4 into kubernetes:master Aug 23, 2019
@k8s-ci-robot k8s-ci-robot added this to the v1.16 milestone Aug 23, 2019
@fejta fejta deleted the bazel branch August 23, 2019 21:47
@krzysied krzysied mentioned this pull request Aug 26, 2019
Closed
@clarketm clarketm mentioned this pull request Aug 26, 2019
Merged
@haircommander haircommander mentioned this pull request Aug 27, 2019
Merged
@mm4tt mm4tt mentioned this pull request Sep 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michelle192837 michelle192837 michelle192837 approved these changes

@chases2 chases2 Awaiting requested review from chases2

@matthyx matthyx Awaiting requested review from matthyx

Assignees

@Katharine Katharine

@michelle192837 michelle192837

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/boskos Issues or PRs related to code in /boskos area/config Issues or PRs related to code in /config area/ghproxy Issues or PRs related to code in /ghproxy area/gopherage Issues or PRs related to code in /gopherage area/greenhouse Issues or PRs related to code in /greenhouse (our remote bazel cache) area/images area/kubetest area/label_sync Issues or PRs related to code in /label_sync area/prow/artifact-uploader Issues or PRs related to prow's artifact-uploader component area/prow/branchprotector Issues or PRs related to prow's branchprotector component area/prow/clonerefs Issues or PRs related to prow's clonerefs component area/prow/config-bootstrapper Issues or PRs related to prow's config-bootstrapper utility area/prow/crier Issues or PRs related to prow's crier component area/prow/deck Issues or PRs related to prow's deck component area/prow/entrypoint Issues or PRs related to prow's entrypoint component area/prow/gcsupload Issues or PRs related to prow's gcsupload component area/prow/gerrit Issues or PRs related to prow's gerrit component area/prow/hook Issues or PRs related to prow's hook component area/prow/horologium Issues or PRs related to prow's horologium component area/prow/initupload Issues or PRs related to prow's initupload component area/prow/jenkins-operator Issues or PRs related to prow's jenkins-operator component area/prow/knative-build Issues or PRs related to prow's knative-build controller component area/prow/mkbuild-cluster Issues or PRs related to prow's mkbuild-cluster component area/prow/mkpj Issues or PRs related to prow's mkpj component area/prow/mkpod Issues or PRs related to prow's mkpod component area/prow/peribolos Issues or PRs related to prow's peribolos component area/prow/phony Issues or PRs related to prow's phony component area/prow/plank Issues or PRs related to prow's plank component area/prow/pod-utilities Issues or PRs related to prow's pod-utilities component area/prow/pubsub Issues or PRs related to prow's pubsub reporter component area/prow/sidecar Issues or PRs related to prow's sidecar component area/prow/sinker Issues or PRs related to prow's sinker component area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow/tide Issues or PRs related to prow's tide component area/prow/tot Issues or PRs related to prow's tot component area/prow Issues or PRs related to prow area/testgrid area/velodrome cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
5 participants
@fejta @k8s-ci-robot @stevekuznetsov @michelle192837 @Katharine